Also test on Chrome for better coverage #409
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d0c9e0 to
9822053
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #409 +/- ##
=========================================
Coverage 85.85% 85.85%
Complexity 182 182
=========================================
Files 1 1
Lines 502 502
=========================================
Hits 431 431
Misses 71 71 ☔ View full report in Codecov by Sentry. |
17deff7 to
f9a3c57
Compare
f9a3c57 to
eb65ec4
Compare
|
After looking at https://github.com/minkphp/MinkSelenium2Driver/actions/runs/12745224912/job/35518756018 (Selenium 3 + Chrome) I now realize why there was an issue reported some time ago about fixing key-related event emulation. But I can't seem to find it. But they don't fail locally :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.