Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

CalvinChanCan
Copy link
Contributor

Not sure if this is allowed and feel free to close if not.

This PR adds an endpoint to update an existing transaction with an updated description, notes, category, and tags and to retrieve the updated transaction.

I appreciate any feedback and guidance.

@burkematthew
Copy link
Collaborator

I'm still thinking on this one. We've so far maintained the stance that this is simply a read-only library. That being said, I do get that if this is a sought after feature and we have contributors willing to do the work, then that stance may need to be reconsidered. If we do, I think we should work on major version v3 that supports a variety of update actions instead of slow trickling them in with various v2 minor versions.

@mrooney
Copy link
Collaborator

mrooney commented Apr 14, 2023

Thanks, this looks cool! I don't have any strong opinions. As Matthew said, previously we've maintained a read-only stance, partially because I would be concerned about there being enough folks available and interested to maintain it. That said, it is probably easier with the REST endpoints.

I think my preferred approach would be a new repo under the same project umbrella named mintapi-write or similar that depends on mintapi and simply adds some endpoints (and tests) so it is more modularized. I imagine this might involve some tweaks to the mintapi project to make things easier to import and extend. If I made a separate empty repo, would you be willing to make it a new module @CalvinChanCan ?

@CalvinChanCan
Copy link
Contributor Author

Thanks @mrooney . I'm unsure if I have enough experience to create a new module. Specifically is the goal of the new module to try to create a wrapper around mintapi with write endpoints?

@mrooney
Copy link
Collaborator

mrooney commented Aug 16, 2023

Apologies for the long delay @CalvinChanCan ! If you are still willing to work on this and a separate module seems overwhelming, I would be fine with just separating files, so that we have an endpoints.py and an endpoints_write.py or similar, and corresponding for the tests. This way, it keeps it all separate and we can import it from other files and makes it easier in the future to make a separate module. Does that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants