β‘οΈ Speed up function _get_initial_max_subplot_ids
by 174%
#119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π 174% (1.74x) speedup for
_get_initial_max_subplot_ids
inplotly/_subplots.py
β±οΈ Runtime :
395 microseconds
β144 microseconds
(best of277
runs)π Explanation and details
Here is an optimized version of your program. The performance hotspot is building the dictionary on every call. This can be avoided by precomputing the dictionary once at module load time and returning a
.copy()
for safety. This avoids repeated dictionary construction and assignment for each call, reducing time spent per invocation.Key optimization:
.copy()
is faster than reconstructing the dict every time, given the small and fixed size of this mapping.All return values and signatures are preserved.
β Correctness verification report:
π Generated Regression Tests Details
To edit these changes
git checkout codeflash/optimize-_get_initial_max_subplot_ids-mb2gjba5
and push.