β‘οΈ Speed up function _get_grid_subplot
by 20%
#127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π 20% (0.20x) speedup for
_get_grid_subplot
inplotly/_subplots.py
β±οΈ Runtime :
102 microseconds
β85.2 microseconds
(best of354
runs)π Explanation and details
Here is an optimized version of your program.
Key optimizations.
fig._grid_ref
andfig.layout
), store them in local variables.rows
andcols
only once.The logic and behavior (including exception text and order) are unmodified.
Notes:
fig._grid_ref
,fig.layout
are minimized and reused.β Correctness verification report:
π Generated Regression Tests Details
To edit these changes
git checkout codeflash/optimize-_get_grid_subplot-mb2hva2a
and push.