This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Noop autocomplete setup if we're not autocompleting #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting up the autocomplete command requires initializing and walking through every subcommand in order to get their completion implementations. This means that if `Autocomplete: true` is on the CLI, every command is initialized on every single invocation. This PR changes it so that we only initialize the autocompletion command if we detect that we're actually being invoked for autocompletion. Luckily our tests already "black-box" (mostly) tested autocompletion so this change can verify that autocompletion still works.
schmichael
approved these changes
Apr 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting up the autocomplete command requires initializing and walking
through every subcommand in order to get their completion
implementations. This means that if
Autocomplete: trueis on the CLI,every command is initialized on every single invocation.
This PR changes it so that we only initialize the autocompletion command
if we detect that we're actually being invoked for autocompletion.
The practical impact is that if
Autocomplete: truenow and you're NOTactively autocompleting then we will only init and run the command that
is requested. This is identical behavior to
Autocomplete: false.Luckily our tests already "black-box" (mostly) tested autocompletion so
this change can verify that autocompletion still works.