Make cpu binary_op easily accessible#2733
Merged
angeloskath merged 2 commits intomainfrom Nov 5, 2025
Merged
Conversation
awni
approved these changes
Nov 4, 2025
Member
awni
left a comment
There was a problem hiding this comment.
Nice. I like the consistency.
Seems like we are converging on a scheme like ``op_{cpu|gpu}{_inplace}( ...)` for back end ops that need to be used during eval.
Member
Author
Yeah exactly. On that note, I should have asked on the main one. Should I rename |
Member
|
I would vote for consistency for sure. I kind of prefer just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the GPU side of things this moves the high level
binary(...)intomlx::corerenamed asbinary_op_cpuandcomparison_op_cpuetc.The point is to simplify things like the one in
matmul.cpp. Not many around so maybe we don't want to merge if we thing this pollutes the namespace (but we have all the lower-level stuff inmlx::core🤷♂️ )