Merge build-cuda and build-linux actions#2783
Merged
zcbenz merged 17 commits intoml-explore:mainfrom Nov 25, 2025
Merged
Conversation
ca95ed3 to
a5852a3
Compare
14bb4dd to
44ab082
Compare
madrob
reviewed
Nov 19, 2025
awni
reviewed
Nov 20, 2025
4be7034 to
42fd2df
Compare
madrob
reviewed
Nov 22, 2025
madrob
reviewed
Nov 22, 2025
madrob
reviewed
Nov 22, 2025
60e3221 to
c27ae2e
Compare
awni
approved these changes
Nov 25, 2025
Member
awni
left a comment
There was a problem hiding this comment.
I'm not sure on the merger here. Seems like it introduces quite a bit of complexity into the github action setup for a small benefit of reducing the duplicate steps between CUDA and linux in some cases. It also makes it somewhat more brittle and harder to change. Imagine we want to do another thing unique for CUDA or we want to add a different device on linux.
That said I don't need to bike shed over the actions script so I'll let you decide what to include here and what to exclude. We can always rearrange in the future.
The cmake improvement is nice, we should update that either way.
fb67db5 to
f11a5f8
Compare
f11a5f8 to
95c1342
Compare
Collaborator
Author
|
I reverted the change that merges |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges the
build-cudaaction intobuild-linux, and adds arm64 CUDA builds (tests are disabled).The CUDA and CPU linux builds are also merged into one job with a matrix — please let me know if you don't think it is a good idea.