[CUDA] Add debug env to save cuda graphs to dot files#2825
Merged
zcbenz merged 1 commit intoml-explore:mainfrom Nov 25, 2025
Merged
[CUDA] Add debug env to save cuda graphs to dot files#2825zcbenz merged 1 commit intoml-explore:mainfrom
zcbenz merged 1 commit intoml-explore:mainfrom
Conversation
awni
reviewed
Nov 24, 2025
mlx/backend/cuda/device.cpp
Outdated
Comment on lines
+436
to
+441
| static std::unordered_set<std::string> saved_keys; | ||
| auto [_, new_graph] = saved_keys.insert(graph_key); | ||
| if (new_graph) { | ||
| auto path = fmt::format("{}_{}.dot", filename, saved_keys.size()); | ||
| CHECK_CUDA_ERROR(cudaGraphDebugDotPrint(graph_, path.c_str(), 0)); | ||
| } |
Member
There was a problem hiding this comment.
Maybe this should save all the graphs and not just the unique graph_key?
Collaborator
Author
There was a problem hiding this comment.
Yeah simply saving all graphs should be enough for most cases.
2fa9c46 to
e3e3aa9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By setting the
MLX_SAVE_CUDA_GRAPHS_DOT_FILE=graphenv the CUDA graphs will be saved tograph_1.dot,graph_2.dot... files.