Make allocator::malloc throw on allocation failure#2874
Merged
zcbenz merged 1 commit intoml-explore:mainfrom Dec 5, 2025
Merged
Make allocator::malloc throw on allocation failure#2874zcbenz merged 1 commit intoml-explore:mainfrom
zcbenz merged 1 commit intoml-explore:mainfrom
Conversation
awni
reviewed
Dec 5, 2025
awni
approved these changes
Dec 5, 2025
Member
awni
left a comment
There was a problem hiding this comment.
Looks great modulo the one comment about cudaMallocAsync. I'm not sure it will return an error if the allocation fails so we may need to check the data pointer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allocator::mallocreturned null buffer when allocation failed, which was designed to makemalloc_or_waitAPI work. Since the API had been removed in #1976, this behavior is no longer needed and the code should just throw in case of allocation failure.