Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bump minimum required Python version#2891

Merged
awni merged 1 commit intoml-explore:mainfrom
ngoldbaum:bump-python
Dec 10, 2025
Merged

bump minimum required Python version#2891
awni merged 1 commit intoml-explore:mainfrom
ngoldbaum:bump-python

Conversation

@ngoldbaum
Copy link
Contributor

Proposed changes

This fixes build issues I see trying to use a Python coming from Pyenv on my personal development environment. For whatever reason, cmake finds the Python3.9 coming from Xcode and uses that to build, despite me having a suitable Python in my PATH.

  -- Building Python bindings.
  -- Found Python: /Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/bin/python3 (found suitable version "3.9.6", minimum required is "3.8") found components: Interpreter Development.Module

See this old github thread with people having a similar problem.

Both Python 3.8 and 3.9 are EOL. The last release of mlx included wheels for 3.10 and newer. IMO the most straightforward fix is to specify that we need 3.10 or newer which avoids using the xcode Python, at least until Apple updates it.

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@awni awni merged commit 208f544 into ml-explore:main Dec 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants