Update nanobind pin to most recent version#2896
Merged
awni merged 4 commits intoml-explore:mainfrom Dec 11, 2025
Merged
Conversation
Closed
Member
Member
Member
|
And there are a few places it's hardcoded in our CI: |
Contributor
Author
|
Thanks for pointing that out, I think I got them all: |
Contributor
Author
|
Building on the GIL-enabled build I also see: So I'll have to fix that one too. |
awni
reviewed
Dec 10, 2025
Member
awni
left a comment
There was a problem hiding this comment.
Nice, thanks! Will merge after tests clear.
Member
|
Actually looks like the lint checks failed. Can you run the pre-commit hooks? |
Contributor
Author
|
Thanks for bearing with me. I might turn actions on for my fork so I can at least run the tests without pinging you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #2895.
The current pin is about a year old. Assuming the CI passes it seems prudent to me to update it.
NB_TYPING_TUPLEis not necessary on Python 3.9 and newer.Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes