Merged
Conversation
awni
reviewed
Dec 19, 2025
.github/workflows/release.yml
Outdated
Comment on lines
+118
to
+122
| - name: Build macOS 26 package | ||
| uses: ./.github/actions/build-macos-release | ||
| with: | ||
| macos-target: 26.0 | ||
| build-backend: ${{ matrix.python-version == '3.10' }} |
Member
There was a problem hiding this comment.
We will do the 26.0 release manually for now until we can get on macOS 26.2 (which is needed to build neural accelerator and RDMA support).
So please remove that part.
Contributor
Author
There was a problem hiding this comment.
To explicitly confirm, we'll still leave it for both the nightly and the PR builds, yes?
Member
There was a problem hiding this comment.
Yes I think it's great to start testing 26.0 👍
For the nightly it's fine.. the only downside is burning compute.. but it's also not necessary so we can remove it and add it back once we do the 26.0 release in CI.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add macOS 26 target to all GitHub build targets
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes