fix distributed all_to_sharded bias shard axis from -2 to -1#2987
Merged
awni merged 2 commits intoml-explore:mainfrom Jan 17, 2026
Merged
fix distributed all_to_sharded bias shard axis from -2 to -1#2987awni merged 2 commits intoml-explore:mainfrom
awni merged 2 commits intoml-explore:mainfrom
Conversation
awni
reviewed
Jan 13, 2026
|
|
||
| def _shard_fn(path, weight): | ||
| if path.endswith("bias"): | ||
| return -1, segments |
Member
There was a problem hiding this comment.
The axis will be 0 max(1 - 2, 0) = 0 which is the same as -1 for the bias since it's 1D.
Contributor
Author
There was a problem hiding this comment.
Hi, thank you for review. The broken test case is I am tring add gpt-oss tensor parallelism on mlx-lm.
See ml-explore/mlx-lm#757.
When shard_inplace mlp.experts.gate_proj, the bias shape is 2D due to multi local expert.
Apply this change, I can run mlx-lm pr success.
Member
|
I don't think this fix is doing anything. But if there is a broken test case you observed then please share and we can revisit it. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Please include a description of the problem or feature this PR is addressing. If there is a corresponding issue, include the issue #.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes