Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Hide symbols by default for mac/linux#3057

Merged
zcbenz merged 2 commits intoml-explore:mainfrom
zcbenz:posix-hidden-symbols
Jan 25, 2026
Merged

Hide symbols by default for mac/linux#3057
zcbenz merged 2 commits intoml-explore:mainfrom
zcbenz:posix-hidden-symbols

Conversation

@zcbenz
Copy link
Collaborator

@zcbenz zcbenz commented Jan 24, 2026

Change the default symbol visibility to hidden for mac/linux, and require using MLX_API macro for exporting symbols. This makes all platforms use the same symbol visibility, which can reduce the cases that code works for mac/linux but fails for windows.

Hiding symbols by default also has some benefits:

  • Smaller binary size: libmlx.so shrinks from 81M to 79M.
  • Faster loading of shared library.

awni
awni approved these changes Jan 24, 2026
View reviewed changes
Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@zcbenz zcbenz force-pushed the posix-hidden-symbols branch from ca88424 to 5bc5fef Compare January 25, 2026 03:28
@zcbenz zcbenz merged commit 3ac892b into ml-explore:main Jan 25, 2026
16 checks passed
@zcbenz zcbenz deleted the posix-hidden-symbols branch January 25, 2026 05:30
@BrewTestBot BrewTestBot mentioned this pull request Jan 27, 2026
Closed
1 task
@bear24rw
Copy link

bear24rw commented Feb 25, 2026

This unfortunately breaks my extension where I was using a bunch of non-public helpers. These were not officially public to begin with but it was very convenient that I could still access them. Whats the best path forward for my use case? Seems my two options now are either maintain a fork of mlx or copy a lot of code into my extension. In my ideal world everything would be accessible and all header files would be shipped in the .whl but some would be under an internal/ namespace indicating it's technically private and prone to change without warning (this is similar to what https://github.com/ocornut/imgui does).

Undefined symbols for architecture arm64:
        "mlx::core::gather_qmm_rhs(mlx::core::array const&, mlx::core::array const&, mlx::core::array const&, std::__1::optional<mlx::core::array> const&, mlx::core::array const&, mlx::core::array&, bool, int, int, int, int, int, mlx::core::metal::Device&, mlx::core::Stream const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>)"
        "mlx::core::broadcast_arrays(mlx::core::array const&, mlx::core::array const&, std::__1::variant<std::__1::monostate, mlx::core::Stream, mlx::core::Device>)"
        "mlx::core::swapaxes_in_eval(mlx::core::array const&, int, int)"
        "mlx::core::contiguous_copy_gpu(mlx::core::array const&, mlx::core::Stream const&)"
        "mlx::core::validate_mode_with_type(std::__1::basic_string_view<char, std::__1::char_traits<char>>, mlx::core::array const&, std::__1::optional<mlx::core::array> const&, std::__1::optional<mlx::core::Dtype>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&)"
        "mlx::core::quantization_mode_to_string(mlx::core::QuantizationMode)"
        "mlx::core::quantization_params_from_mode(mlx::core::QuantizationMode

@zcbenz
Copy link
Collaborator Author

zcbenz commented Feb 26, 2026

@bear24rw I think for now we can just export those functions with MLX_API since you are using them in extension — we are already exporting a few non-public APIs for users' convenience.

@bear24rw
Copy link

bear24rw commented Feb 26, 2026

@zcbenz I think it might be a bit of game of whack a mole since those functions I listed are just what I happened to be using today but my extension is still in development. I've decided to just go down the fork mlx route with the hope that one day it would be upstreamed anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awni awni awni approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zcbenz @bear24rw @awni