Do not require ConcurrentManagedAccess when not used#3062
Merged
zcbenz merged 1 commit intoml-explore:mainfrom Jan 27, 2026
Merged
Do not require ConcurrentManagedAccess when not used#3062zcbenz merged 1 commit intoml-explore:mainfrom
zcbenz merged 1 commit intoml-explore:mainfrom
Conversation
awni
approved these changes
Jan 25, 2026
Member
awni
left a comment
There was a problem hiding this comment.
Looks great! Not sure on the test failure.. looks like something strange is going on there 🤔
398ea74 to
bf7029f
Compare
Collaborator
Author
|
Calling |
55ab61e to
be29501
Compare
be29501 to
bb09c16
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do the check of
ConcurrentManagedAccesscapacity inAtomicEventso MLX can work on consumer hardwares when CPU/GPU synchronization is not required.Also did some refactoring:
cu::Devicebecomes cheap to create — the creations of cudnn and cublasLt are now lazy.cu::Devices during initialization and store them in a vector — this is more efficient than using hash map since we have code iterating all devices (SmallSizePool).