Allow empty records for JSON generation #216
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0dcef38 to
2954fd9
Compare
szg251
approved these changes
Apr 12, 2024
bladyjoker
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
record MyEmptyRecord = { }
Is not something LB can swallow at the moment. Why? I don't recall exactly, but it was a decision that spanned parts from the Compiler to the Codegen. Nowadays, I think we error on empty records, and we have no syntax for empty products.
However, I don't think this change is problematic. If anything, when we introduce empty product/records this would then just work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the restriction of generating code instances for only non empty JSON objects.
Indeed, the empty JSON object
is valid JSON, so schemas like
should be valid.