Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Removed ellipsis in combination with time mask. - #2890

Merged
dengemann merged 1 commit into
mne-tools:maint/0.10from
jaeilepp:ellipsis
Feb 16, 2016
Merged

Removed ellipsis in combination with time mask.#2890
dengemann merged 1 commit into
mne-tools:maint/0.10from
jaeilepp:ellipsis

Conversation

@jaeilepp

Copy link
Copy Markdown
Contributor

No description provided.

@dengemann

Copy link
Copy Markdown
Member

Looks good. We should actually see which numpy version is protesting to the previous syntax.

@jaeilepp

Copy link
Copy Markdown
Contributor Author

There are quite a few of test failures, but I suppose it is safe to merge?

@dengemann

Copy link
Copy Markdown
Member

There are quite a few of test failures, but I suppose it is safe to merge?

let's not assume that ... having a look.

@dengemann

Copy link
Copy Markdown
Member

seems unrelated, we only changed testing code here, right?

@jaeilepp

Copy link
Copy Markdown
Contributor Author

Actually the changes are in tfr.py and psd.py, but the equivalent changes passed on master. This maint branch just doesn't have the same fixes in place.

@larsoner

Copy link
Copy Markdown
Member

Looks okay to me, failures are unrelated

dengemann added a commit that referenced this pull request Feb 16, 2016
Removed ellipsis in combination with time mask.
@dengemann
dengemann merged commit 4673e89 into mne-tools:maint/0.10 Feb 16, 2016
@agramfort

Copy link
Copy Markdown
Member

@jaeilepp can you backport, tag a maintenance release, and update the debian package?

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants