WIP ENH: Better test coverage - #910
Conversation
There was a problem hiding this comment.
By the way, these comparisons were not working for me. I have numpy 1.8, and this comparison was evaluating to True.
There was a problem hiding this comment.
You did the right thing. Seeing this I also would have suggested using LooseVersion.
|
LG8TM feel free to merge when you're done |
|
@dengemann I added a test that I think should work that causes a failure in plot_epochs. Can you take a look when you get a chance? FYI, I added some keypress tests for http://matplotlib.1069221.n5.nabble.com/Emulating-keypress-and-mouse-clicks-td42534.html |
There was a problem hiding this comment.
This function wasn't tested before (tsk, tsk)
|
BTW so far, this PR takes the unaccounted-for lines in viz from 438 to 351, the bulk of which is due to button-press emulation. I think we'll be able to do much better once I figure out the click emulation. |
|
@Eric89GXL PR sent |
There was a problem hiding this comment.
Interesting, I've never seen else in a try block, did not know this is valid Python.
WIP ENH: Better test coverage
For 0.7 or not, either way is fine by me, but I vote 0.7 (I can probably get it done tomorrow). These changes make
utilsandfixes, andvizhave better coverage.