Feature: support destination persistent connections attribute#13
Feature: support destination persistent connections attribute#13kwanhur wants to merge 2 commits intomoby:masterfrom
Conversation
Signed-off-by: kwanhur <[email protected]>
|
check failed details do not relate with the feature codes |
andrewsykim
left a comment
There was a problem hiding this comment.
@kwanhur looks like github thinks the email you are using is invalid, would it be possible to use a valid email address?
| case ipvsDestAttrInactiveConnections: | ||
| d.InactiveConnections = int(native.Uint16(attr.Value)) | ||
| case ipvsDestAttrPersistentConnections: | ||
| d.PersistentConnections = int(native.Uint16(attr.Value)) |
There was a problem hiding this comment.
Looking at the kernel implementation this should be uint32?
There was a problem hiding this comment.
Yeap, the connection attributes ActiveConnections InactiveConnections PersistentConnections also should be uint32. Unified could be better.
it has been valid :-) |
|
Seeing this on github actions: Maybe it's been fixed now, can you rebase and fix conflicts? |
Signed-off-by: kwanhur <[email protected]>
conflicts have been fixed ：） |
|
Ping @andrewsykim how about this PR? |
Add
PersistentConnectionsattribute inDestinationstruct