Open
Conversation
Signed-off-by: kwanhur <[email protected]>
andrewsykim
reviewed
Apr 28, 2020
ipvs.go
Outdated
|
|
||
| ver := uint(res.version) | ||
| return &Info{ | ||
| Version: &Version{ |
Collaborator
There was a problem hiding this comment.
Can we put the conversion of ver to Version in a separate function so we can add unit tests?
Contributor
Author
There was a problem hiding this comment.
version as one attribute of ipvsInfo, we should test it as a whole? like test case TestInfo
Member
There was a problem hiding this comment.
@kwanhur I agree with @andrewsykim.
We can test different inputs for the conversion and not rely on the netlink of the test system.
cpuguy83
requested changes
Aug 5, 2021
| } | ||
|
|
||
| // parseInfo given a ipvs netlink response this function will respond with a valid info entry, an error otherwise | ||
| func (i *Handle) parseInfo(msg []byte) (*ipvsInfo, error) { |
Member
There was a problem hiding this comment.
I don't think this needs to be bound to *Handle?
Signed-off-by: kwanhur <[email protected]>
Signed-off-by: kwanhur <[email protected]>
Contributor
Author
|
@andrewsykim @cpuguy83 add two api |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetch ipvs info with API
info := i.GetInfo()fetch version number just call
info.Version.String(), example: 1.2.1fetch connection table size call
info.ConnTableSize, example: 4096 .