Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP] Generate french container names#19628

Closed
dgageot wants to merge 2 commits into
moby:masterfrom
dgageot:os-souverain
Closed

[WIP] Generate french container names#19628
dgageot wants to merge 2 commits into
moby:masterfrom
dgageot:os-souverain

Conversation

@dgageot

@dgageot dgageot commented Jan 24, 2016

Copy link
Copy Markdown
Contributor

This is still work in progress and a first step towards the support of a french version of Docker, namely Marcel.

  • Still need to add names to the NameGenerator. By using ministers names, I should be able to find women names.
  • Need to plug this french generator in somehow

Another PR should follow to rename all docker actions to marcel actions: docker kill -> marcel extermine

We might also as @shykes mentioned move this code to a container and find a way to plugin it in

Signed-off-by: David Gageot [email protected]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/name/nom/ ? 😉

@AdrieanKhisbe

Copy link
Copy Markdown

Nom mais Oh
Ils sont où les Mendès, Clémenceau, Rocard, Robespierre, Condorcet, Turgot, Compte ? :)

@nightmared

Copy link
Copy Markdown

panic: runtime error: index out of range --> something very bad happened

@nightmared

Copy link
Copy Markdown

@moviruo, I will lunch and then add your corrections as a PR on top of @dgageot branch

EDIT: Still cloning the repo (had some network issues currently)

@cyphar

cyphar commented Jan 24, 2016

Copy link
Copy Markdown
Contributor

This PR has just reminded me that names-generator.go needs to be renamed (dashes are ugly). But yes, 11/10 trolling :trollface:.

@nightmared

Copy link
Copy Markdown

Does my PR correct everything @moviuro ?

@dgageot

dgageot commented Jan 24, 2016

Copy link
Copy Markdown
Contributor Author

@t0b1nux @moviuro The thing is, I'm not sure french accents are accepted for container names. I wanted to check first.

@nightmared

Copy link
Copy Markdown

@dgageot I hope so, otherwise this thread is a nonsense

@dgageot

dgageot commented Jan 24, 2016

Copy link
Copy Markdown
Contributor Author

@t0b1nux Right now it's not supported. Yet another challenge to overcome

@nightmared

Copy link
Copy Markdown

Well, that's more funny then ;)

@AdrieanKhisbe

Copy link
Copy Markdown

At least there is no way to upset Clemenceau by mistake:
cf https://fr.wikipedia.org/wiki/Georges_Clemenceau#cite_note-1
📖 :trollface: 🎩

@cyphar

cyphar commented Jan 24, 2016

Copy link
Copy Markdown
Contributor

Do all systems we support have unicode support (I'm looking at you, Windows)?

@nightmared

Copy link
Copy Markdown

Sorry, but I don't have windows, and I guess most docker users doesn't have it as well. If docker is mainly targeted at Linux (even if Microsoft is doing things), unicode support shouldn't be a problem

@cyphar

cyphar commented Jan 25, 2016

Copy link
Copy Markdown
Contributor

Actually, Docker (the client and the daemon) can run on Windows.

@nightmared

Copy link
Copy Markdown

@cyphar Yeah, but only modern versions of it, right ? And theses versions supports Unicode (I hope so)

@nightmared

Copy link
Copy Markdown

@dgageot Have you worked on supporting unicode in docker name generator or have any advice on how to do it ?

@jessfraz

Copy link
Copy Markdown
Contributor

it would be cooler if this was like a "french mode only thing ;)"

@dgageot

dgageot commented Jan 25, 2016

Copy link
Copy Markdown
Contributor Author

Hi @jfrazelle, how do you imagine the "mode français" would be activated?

@jessfraz

Copy link
Copy Markdown
Contributor

Idk daemon flag maybe :)

On Mon, Jan 25, 2016 at 11:43 AM, David Gageot [email protected]
wrote:

Hi @jfrazelle https://github.com/jfrazelle, how do you imagine the
"mode français" would be activated?


Reply to this email directly or view it on GitHub
#19628 (comment).

@thaJeztah

Copy link
Copy Markdown
Member

daemon drapeau probably

@dgageot

dgageot commented Jan 25, 2016

Copy link
Copy Markdown
Contributor Author

Let's go for a drapeau then!

@calavera

calavera commented Feb 1, 2016

Copy link
Copy Markdown
Contributor

Thanks. I think we should not move forward with this.

@dgageot

dgageot commented Feb 1, 2016

Copy link
Copy Markdown
Contributor Author

@calavera Yes, that was really more a joke than anything!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants