Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[17.03] Bump 17.03.2#33339

Merged
thaJeztah merged 2 commits into
moby:17.03.xfrom
cpuguy83:bump_17.03.2
May 24, 2017
Merged

[17.03] Bump 17.03.2#33339
thaJeztah merged 2 commits into
moby:17.03.xfrom
cpuguy83:bump_17.03.2

Conversation

@cpuguy83

Copy link
Copy Markdown
Member

No description provided.

@cpuguy83

Copy link
Copy Markdown
Member Author

ping @mlaventure @thaJeztah

@runcom

runcom commented May 22, 2017

Copy link
Copy Markdown
Member

👍

@mlaventure

Copy link
Copy Markdown
Contributor

No rc? :)

Also, CHANGELOG.md 👼

Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Kenfe-Mickael Laventure <[email protected]>
@mlaventure

Copy link
Copy Markdown
Contributor
  • Updated version to 17.03.2-ce-rc1
  • Added initial CHANGELOG

@mlaventure mlaventure requested a review from thaJeztah May 22, 2017 22:15

@andrewhsu andrewhsu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

future date changelog version

Comment thread CHANGELOG.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version 17.03.2-ce and future date to 2017-05-29 to give time for rc cycle

@mlaventure mlaventure force-pushed the bump_17.03.2 branch 2 times, most recently from ea3629b to a2eaa50 Compare May 22, 2017 22:26

@andrewhsu andrewhsu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread CHANGELOG.md Outdated

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at the pr yet as I'm on mobile, but this should just be fixing some edge axes around the "z"option. The option itself has been around for awhile.

Comment thread CHANGELOG.md Outdated

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Fix an issue with backporting mount spec to older volumes"

@mlaventure

Copy link
Copy Markdown
Contributor

@cpuguy83 updated

@cpuguy83 cpuguy83 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlaventure

Copy link
Copy Markdown
Contributor

ping @thaJeztah

Comment thread CHANGELOG.md Outdated

@tiborvass tiborvass May 23, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo s/:/](https:/

Comment thread CHANGELOG.md Outdated

@tiborvass tiborvass May 23, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the link to the cherrypick PR, but it's weird, because it's not easy to know what exactly corresponds to this fix. I would put the link to the original PR instead. Or both?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the cherrypick PR didn't cherrypick all in one, I would prefer the cherrypick PR since it's closest to what actually is changed in the release branch. But in this case it bundles too much and it's hard to follow.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had initially put the original one, but it leads to the wrong branch. I'll put both with ref I guess

Signed-off-by: Kenfe-Mickael Laventure <[email protected]>
@mlaventure

Copy link
Copy Markdown
Contributor

Fix the typo, and added the reference PR as needed if the fix was cherry-picked along side other fixes

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit eef6495 into moby:17.03.x May 24, 2017
@cpuguy83 cpuguy83 deleted the bump_17.03.2 branch September 20, 2017 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants