Thanks to visit codestin.com
Credit goes to github.com

Skip to content

pkg/system: deprecate types and functions that are only used internally #49098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2024
Merged

pkg/system: deprecate types and functions that are only used internally #49098

merged 1 commit into from
Dec 16, 2024

Conversation

thaJeztah
Copy link
Member

These types and functions are only used internally (through pkg/archive). Deprecate them, and mark them for removal.

This deprecates the Lstat(), Mkdev(), Mknod(), FromStatT() and Stat() functions, and related StatT type.

- What I did

- How I did it

- How to verify it

- Description for the changelog

pkg/system: deprecate `Lstat()`, `Mkdev()`, `Mknod()`, `FromStatT()` and `Stat()` functions, and related `StatT` types. These were only used internally, and will be removed in the next release.

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 28.0.0 milestone Dec 16, 2024
@thaJeztah thaJeztah self-assigned this Dec 16, 2024
@thaJeztah
pkg/system: deprecate types and functions that are only used internally
f0ce367 
These types and functions are only used internally (through pkg/archive).
Deprecate them, and mark them for removal.

This deprecates the `Lstat()`, `Mkdev()`, `Mknod()`, `FromStatT()`
and `Stat()` functions, and related `StatT` type.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the deprecate_pkg_system branch from 3f37aaa to f0ce367 Compare December 16, 2024 10:41
@thaJeztah thaJeztah mentioned this pull request Dec 16, 2024
Merged
@thaJeztah
Copy link
Member Author

Flaky test; tracked in #48881

=== FAIL: github.com/docker/docker/integration/networking TestPortMappedHairpinWindows (15.48s)
    nat_windows_test.go:108: assertion failed: error is not nil: Post "http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.48/containers/3245eaa72401688caec385f1d024184170e9a692f0fffe2614e2a687c68853d4/start": context deadline exceeded
    panic.go:629: assertion failed: error is not nil: Error response from daemon: error while removing network: network clientnet id 567e2233732e08fe2354fb8a82ca4b5bd200f65e9b3fdc41131fd24d1b94be40 has active endpoints

@thaJeztah thaJeztah marked this pull request as ready for review December 16, 2024 13:09
@thaJeztah thaJeztah merged commit 51abfcb into moby:master Dec 16, 2024
146 checks passed
@thaJeztah thaJeztah deleted the deprecate_pkg_system branch December 16, 2024 15:05
@thaJeztah thaJeztah mentioned this pull request Dec 16, 2024
Merged
@thaJeztah thaJeztah mentioned this pull request Jan 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvoland vvoland vvoland approved these changes

Assignees

@thaJeztah thaJeztah

Labels
area/go-sdk impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK process/cherry-picked status/2-code-review
Projects
None yet
Milestone
28.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thaJeztah @vvoland