[28.x backport] graphdriver/windows: Potential fix for access denied #50871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `winio.RunWithPrivileges` to get the privileges. It's better because it also locks the Go runtime thread so if the Go scheduler decides to run this code on a different thread, it will still have the expected privileges. A naive attempt at fixing an error experienced by Docker Desktop user when using Windows containers: ``` failed to register layer: re-exec error: exit status 1: output: hcsshim::ProcessUtilityVMImage \\?\C:\ProgramData\Docker\windowsfilter\<hash1>\UtilityVM: Access is denied. failed to register layer: re-exec error: exit status 1: output: hcsshim::ProcessBaseLayer \\?\C:\ProgramData\Docker\windowsfilter\<hash2>: Access is denied. failed to register layer: re-exec error: exit status 1: output: hcsshim::ProcessBaseLayer \\?\C:\ProgramData\Docker\windowsfilter\<hash3>: Access is denied. ``` Unfortunately I can't reproduce the issue on a Windows VM, but this definitely won't hurt. At least, I verified that the daemon still works on Windows. Inspired by: containerd/containerd#8206 Signed-off-by: Paweł Gronowski <[email protected]> (cherry picked from commit f66f555) Signed-off-by: Paweł Gronowski <[email protected]>
robmry
approved these changes
Sep 2, 2025
akerouanton
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
winio.RunWithPrivilegesto get the privileges. It's better because it also locks the Go runtime thread so if the Go scheduler decides to run this code on a different thread, it will still have the expected privileges.A naive attempt at fixing an error experienced by Docker Desktop user when using Windows containers:
Unfortunately I can't reproduce the issue on a Windows VM, but this definitely won't hurt.
At least, I verified that the daemon still works on Windows.
Inspired by: containerd/containerd#8206
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)