Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update client MaxAPIVersion to 1.53#51725

Merged
robmry merged 2 commits intomoby:masterfrom
robmry:max-api-1.53
Dec 16, 2025
Merged

Update client MaxAPIVersion to 1.53#51725
robmry merged 2 commits intomoby:masterfrom
robmry:max-api-1.53

Conversation

@robmry
Copy link
Contributor

@robmry robmry commented Dec 15, 2025

- What I did

The daemon's MaxAPIVersion was updated to 1.53 in commit f6b1488.

This updates the client's MaxAPIVersion.

It also removes the check that stopped the daemon from backfilling empty PortBindings in API 1.53, see:

- How I did it

- How to verify it

- Human readable description for the release notes

Update `MaxAPIVersion` to 1.53.

- A picture of a cute animal (not mandatory but encouraged)

@robmry robmry added this to the 29.2.0 milestone Dec 15, 2025
@robmry robmry added module/client kind/other Not a feature, bugfix or enhancement. impact/changelog area/api API labels Dec 15, 2025
@vvoland
Copy link
Contributor

vvoland commented Dec 15, 2025

Needs a revendor

@robmry robmry force-pushed the max-api-1.53 branch 2 times, most recently from 003a1cf to 5065ada Compare December 15, 2025 19:46
@github-actions github-actions bot added area/networking Networking area/daemon Core Engine labels Dec 15, 2025
@robmry robmry requested a review from vvoland December 15, 2025 19:48
@vvoland
Copy link
Contributor

vvoland commented Dec 16, 2025

The next API version will drop empty `PortBindings` list altogether.

We can probably also adjust the changelog

- introduced by commit 0ca7ac3 ("daemon: backfill empty PBs
  slices for backward compat")

Signed-off-by: Rob Murray <[email protected]>
The daemon's MaxAPIVersion was updated in commit f6b1488.

Signed-off-by: Rob Murray <[email protected]>
@robmry
Copy link
Contributor Author

robmry commented Dec 16, 2025

We can probably also adjust the changelog

I've changed it to "A future API version ..." (and added the "ci/validate-only" label).

Copy link
Contributor

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@robmry robmry merged commit 25fbe6c into moby:master Dec 16, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants