gha: Set timeout-minutes on build-dind and labeler jobs#52806
Merged
Conversation
vvoland
reviewed
Jun 11, 2026
| contents: read | ||
| pull-requests: write | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 120 |
Contributor
There was a problem hiding this comment.
We can keep this one even lower - like 5 minutes?
Contributor
Author
There was a problem hiding this comment.
Updated to 5 minutes. Thanks!
b41b45f to
1da00ff
Compare
Member
|
CI is failing on the commit message; Error: Commit 1da00ffe9975ffa94008099bd479c3facd70dd8e contains a GitHub issue or PR reference. Reference commit hashes instead.Can you remove the |
These were the only two jobs running directly via `runs-on:` that did not have a `timeout-minutes` guardrail. Add 120 minutes as a starting point to prevent runaway jobs, matching the existing convention used elsewhere in the workflows. Tuning each job's timeout to its usual runtime is left as a follow-up, as suggested in the issue. Signed-off-by: Takumi Akasaka <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
1da00ff to
7e8d2d1
Compare
thaJeztah
approved these changes
Jun 12, 2026
thaJeztah
left a comment
Member
There was a problem hiding this comment.
LGTM (removed the ticket reference from the commit message)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
build-dindjob inci.ymland thelabelerjob inlabeler.ymlwere the only two jobs running directly viaruns-on:that did not have atimeout-minutesguardrail. This adds a 120-minute timeout to both, following the maintainer guidance in the issue to use 120 minutes as a conservative starting point to prevent runaway jobs:Per-job tuning to each job's usual runtime is left as a follow-up, as also suggested in the issue.
Other workflow files (
bin-image.yml,vm.yml,zizmor.yml,windows-2022.yml,windows-2025.yml) only call reusable workflows viauses:, sotimeout-minutescannot be set on those caller jobs — the reusable workflows they call (.dco.yml,.vm.yml,.windows.yml) already define their owntimeout-minutes.Release notes (optional)