include --releasever=/ in mkimage-yum.sh#6992
Conversation
I didn't realize the commit required a Docker-DCO so it failed the travis-ci build. So I removed the commit from my forked repo. Now it looks like there is a pull request with no commit. So here it is again: Needed to add '--releasever=/' flag to run yum groupinstall on Centos7 (didn't try on anything else). This snippet from yum man page explains why: ``` Note: You may also want to use the option --releasever=/ when creating the installroot as otherwise the $releasever value is taken from the rpmdb within the installroot (and thus. will be empty, before creation). ``` Docker-DCO-1.1-Signed-off-by: Matt Schurenko <[email protected]> (github: mschurenko)
|
@tianon ? |
|
At, sorry for the delay! Doesn't this change effectively make it impossible to build (for example) a CentOS 6 image on 7? |
|
This snippet concerns me in regards to "cross-yuming" (Yes, I just made that up) and the integrity of the host. It sounds like the hosts cache is used regardless of the install root. _repoquery(1):_ |
|
ping @tianon |
|
@thomassuckow so do you think our grand idea of "cross yumming" is viable, or do we maybe need to split this script into different varieties based on host OS? |
|
It may be viable. I don't know much about some of the more exotic yum based os's. One of these days I may get around to making a small centos7 container and see if there is anything I can do about this releasever issue. |
|
@tianon verdict? |
|
ping @tianon |
|
Since the script does specifically say "centos" at the top, I'm inclined to merge this. We can always hash it out more in a future PR if someone is interested in investing the time into it. |
include --releasever=/ in mkimage-yum.sh
This script failed when trying to create a docker image based on centos 7. Adding "--releasever=/" fixed it. According to yum man page:
Docker-DCO-1.1-Signed-off-by: Matt Schurenko [email protected] (github: mschurenko)