daemon logging: unifying output and timestamps#8238
Conversation
6d1f856 to
2927510
Compare
|
@vbatts drone.io tests are failing |
2927510 to
82f9c55
Compare
|
not sure why the time format looks different on drone.io ... but i fixed it |
|
LGTM |
There was a problem hiding this comment.
Doesn't it make more sense to put the time first and then the priority? Just curious.
There was a problem hiding this comment.
I'm down for what ever
There was a problem hiding this comment.
@vbatts I guess it's easier for scripting: merging logs and then sorting them would be possible if the first thing is the timestamp
|
I would love to give |
|
@vbatts i think that should be separate from this PR. |
|
@tiborvass fair. Should I remove the timestamp to engine Logf from this PR? |
|
@vbatts that can stay. I just find it easier to merge this PR without rethinking engine logging. |
|
@tiborvass yup. carry on. |
There was a problem hiding this comment.
I don't like having a defer here. I would just call it
82f9c55 to
6acc569
Compare
|
@crosbymichael fixed |
A little refactor of the ./pkg/log so engine can have a logger instance Signed-off-by: Vincent Batts <[email protected]>
6acc569 to
92df943
Compare
|
@tiborvass i've put the timestamp first now. PTAL |
|
LGTM |
|
LGTM |
daemon logging: unifying output and timestamps
A little refactor of the ./pkg/log so engine can have a logger instance
Signed-off-by: Vincent Batts [email protected]
ping @shykes @vieux @crosbymichael for the ./docker and ./pkg/log changes
ping @crosbymichael for the ./pkg/iptables changes
ping @shykes for the ./engine changes
ping @tiborvass since he and i conspired ... 👅