Save start error into State.Error when the container fails to start#8315
Merged
Conversation
Contributor
Author
|
I think this might resolve #8294 too |
Contributor
|
LGTM |
Contributor
There was a problem hiding this comment.
can we also pass the error
88e1ad1 to
873462d
Compare
Contributor
Author
|
@jfrazelle thanks, i didnt know about |
Contributor
|
@dqminh it's a gamechanger :) thanks! |
Contributor
|
LGTM (for after 1.3) |
Contributor
|
@dqminh needs a rebase |
when a container failed to start, saves the error message into State.Error so that it can be retrieved when calling `docker inspect` instead of having to look at the log Docker-DCO-1.1-Signed-off-by: Daniel, Dao Quang Minh <[email protected]> (github: dqminh)
873462d to
fb6ee86
Compare
Contributor
Author
|
@tiborvass rebased. PTAL |
jessfraz
pushed a commit
that referenced
this pull request
Oct 24, 2014
Save start error into State.Error when the container fails to start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a container failed to start, in addition to returning the error message in output, we also save that error message into
State.Errorso it can be read fromdocker inspectagain by user without having to start the container again / read from the logs.This is particularly helpful for container management systems where we don't want to save last error message returned in
POST /containers/:id/startoutput, but still want to let users read it later so they can resolve it.Docker-DCO-1.1-Signed-off-by: Daniel, Dao Quang Minh [email protected] (github: dqminh)