Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix typo#8352

Merged
tiborvass merged 1 commit into
moby:masterfrom
zachborboa:patch-1
Oct 29, 2014
Merged

Fix typo#8352
tiborvass merged 1 commit into
moby:masterfrom
zachborboa:patch-1

Conversation

@zachborboa

Copy link
Copy Markdown
Contributor

No description provided.

@zachborboa zachborboa mentioned this pull request Oct 2, 2014
@jessfraz

jessfraz commented Oct 2, 2014

Copy link
Copy Markdown
Contributor

@zachborboa In the future it's preferred that you don't open a new pull request. You can force push to your branch with git commit --amend -a --no-edit && git push -f.

@jessfraz

Copy link
Copy Markdown
Contributor

LGTM ping @fredlf

@fredlf

fredlf commented Oct 20, 2014

Copy link
Copy Markdown
Contributor

@zachborboa, I hate to say it for such a minor (but appreciated!) fix, but it needs to be signed with the DCO as per the instructions here: https://github.com/docker/docker/blob/master/CONTRIBUTING.md.

It's a legal requirement, apparently, so I don't have the authority to make exceptions. Sorry. At least you can sign and amend your commit as @jfrazelle recommends.

Signed-off-by: Zach Borboa <[email protected]>
@SvenDowideit

Copy link
Copy Markdown
Contributor

this is not a doc change, so needs someone like @crosbymichael @vieux @unclejack @tiborvass to weigh in :)

@jessfraz

Copy link
Copy Markdown
Contributor

@SvenDowideit apologies that was my bad

@tiborvass

Copy link
Copy Markdown
Contributor

LGTM

tiborvass added a commit that referenced this pull request Oct 29, 2014
@tiborvass tiborvass merged commit 290222c into moby:master Oct 29, 2014
@zachborboa zachborboa deleted the patch-1 branch October 30, 2014 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants