registry/endpoint: make it testable#8387
Merged
Merged
Conversation
Contributor
|
LGTM |
Contributor
|
@vbatts can you rebase and then I think we can merge this one pretty soon after |
Signed-off-by: Vincent Batts <[email protected]>
31d02e6 to
3eba719
Compare
Contributor
Author
|
@jfrazelle rebased |
Contributor
|
awesome @dmcgowan can you review please :) |
Member
|
LGTM |
Contributor
|
ping at @vieux or @tiborvass for the merge? |
Contributor
|
LGTM |
vieux
added a commit
that referenced
this pull request
Oct 29, 2014
registry/endpoint: make it testable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@crosbymichael and @dmcgowan I know it's too late for 1.3, but this adds back the tests we started, and make the initializer more testable.
Signed-off-by: Vincent Batts [email protected]