Add info on --device flag permissions ':rwm'#8465
Merged
crosbymichael merged 1 commit intoOct 16, 2014
Merged
Conversation
a8e8eb8 to
5f9f1f5
Compare
|
LGTM |
Contributor
|
LGTM |
Contributor
There was a problem hiding this comment.
Oxford comma after write please!
Contributor
|
Docs LGTM, but do we need an LGTM for the code too? |
Contributor
|
@fredlf I don't think that is necesary. The only thing that's changed is a single string. |
Signed-off-by: Sven Dowideit <[email protected]> Docker-DCO-1.1-Signed-off-by: Sven Dowideit <[email protected]> (github: SvenDowideit)
5f9f1f5 to
2709c46
Compare
Contributor
Author
|
yes, code, is code. @crosbymichael @tiborvass @vieux |
Contributor
|
Code LGTM |
Contributor
Author
|
mmm, looking at the MAINTAINERS file, i think we need @vieux, @crosbymichael, or @shykes ? |
Contributor
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Oct 16, 2014
…ssion-options Add info on --device flag permissions ':rwm'
SvenDowideit
pushed a commit
to SvenDowideit/docker
that referenced
this pull request
Oct 17, 2014
…ermission-options Add info on --device flag permissions ':rwm' (cherry picked from commit 4b59472) Docker-DCO-1.1-Signed-off-by: Michael Crosby <[email protected]> (github: SvenDowideit)
SvenDowideit
pushed a commit
to SvenDowideit/docker
that referenced
this pull request
Nov 6, 2014
…ermission-options Add info on --device flag permissions ':rwm' (cherry picked from commit 4b59472)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sven Dowideit [email protected]
@fredlf @jamtur01 @ostezer
thanks @timthelion from #5910