daemon: resolve the graphdriver to show#8510
Conversation
There was a problem hiding this comment.
I'm not totally sure that we want to get this information by overwritting the configuration from a client. Maybe getting this via n Info method is better
There was a problem hiding this comment.
@crosbymichael right now we can get these information from two ways: the daemon method and the daemonCfg, if we want to print this information in mainDaemon(), I'm not sure how we can use a method to get that. And daemonCfg.GraphDriver is out dated in NewDaemonFromDirectory(), so I think update this is reasonable.What do you think?
There was a problem hiding this comment.
In docker/daemon.go can you just call daemon.Info() or something like that to get the information that you want?
graphdriver is not always specified when the log printed, because it's provided in another thread. This patch will fix this. Signed-off-by: Qiang Huang <[email protected]>
|
@crosbymichael what about now? |
|
@crosbymichael @vieux ping... |
|
LGTM |
1 similar comment
|
LGTM |
daemon: resolve the graphdriver to show
graphdriver is not always specified when the log printed, because
it's provided in another thread. This patch will fix this.
Signed-off-by: Qiang Huang [email protected]