Fix tag an existed tag name of a repository#8511
Merged
Merged
Conversation
Signed-off-by: Lei Jitang <[email protected]>
Contributor
There was a problem hiding this comment.
sorry let me explain better you can change these to
errorOut(err, t, out)
the errorOut function will handle the printing of the error :)
Contributor
Author
There was a problem hiding this comment.
@jfrazelle errorOut(err, t, fmt.Sprintf("%v %v", out, err)) is also used in tests TestTagUnprefixedRepoByName and TestTagUnprefixedRepoByID.
Maybe it is need a cleanup
Contributor
There was a problem hiding this comment.
hmm ya we can send a cleanup PR down the road :) thanks!
Contributor
Author
|
update |
Contributor
There was a problem hiding this comment.
hey sorry we got rid of the errorOut function in a cleanup PR so if you could just change these to a t.Fatal that would be great :)
Signed-off-by: Lei Jitang <[email protected]>
Contributor
Author
|
update the PR,change errorOut to t.Fatal |
Contributor
|
awesome thank you LGTM |
Contributor
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Oct 20, 2014
Fix tag an existed tag name of a repository
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace #8303
replace #8487
When tag a image with a tag name which is existed in the repository,
docker should prompt it is conflicted and it will only worked when with
a -f option.But the docker doesn't work like that,it will just
replace the image whether you have a -f option or not.View the
code you can find that if an repoName is existed,it will never go
to check if 'force' option is set or not.