system: Add MemInfo utility.#8550
Merged
Merged
Conversation
Member
Author
|
@vieux @crosbymichael: Let me know if this is a good location for this utility. |
Contributor
|
I think it's fine. Maybe add some comments to the exported funcs and types |
Contributor
|
ping @aluzzardi |
Contributor
|
MemInfo, ErrMalformed and ReadMemInfo require comments. |
MemInfo provides a simple API to get memory information from the system. Signed-off-by: Andrea Luzzardi <[email protected]>
Member
Author
|
PTAL |
Contributor
|
LGTM |
Member
Author
|
@unclejack: Regarding ErrMalformed, my philosophy is that errors.New("this is the documentation and the comment is redundant"). Thoughts? |
Contributor
|
@aluzzardi That's fair enough. LGTM |
Member
Author
|
Thanks! Anyone willing to press the merge button? I'd rather not merge my own stuff in. |
unclejack
added a commit
that referenced
this pull request
Oct 23, 2014
system: Add MemInfo utility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MemInfo provides a simple API to get memory information from the
system.
Signed-off-by: Andrea Luzzardi [email protected]