Fix support for --env-file in bash completion#8561
Merged
Conversation
Signed-off-by: Harald Albers <[email protected]>
Contributor
|
ping @jfrazelle |
Contributor
|
nice LGTM |
Contributor
|
ping @tianon |
Member
|
Oh we are out of freeze :D LGTM |
tianon
added a commit
that referenced
this pull request
Oct 17, 2014
Fix support for --env-file in bash completion
Member
Author
|
I'm quite disappointed that the recent 1.3.1 release (Debian package) ships with the old version of bash completion, not including this change (I verified the package contents manually). Is there some kind of manual step required for including the bash completion into the build that is not properly documented? I'd really like to see this included in the next release. |
Member
|
It will be in the next major release (1.4). Minor releases are only for |
Member
Author
|
That makes sense. Thanks for clarifying, and for doing it so quickly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--env-fileoption ofdocker runanddocker createin bash completion is not implemented properly.To reproduce:
docker run --enand tab twice. The available completions will be:--entrypoint --envdocker create --enand tab twice. The available completions will be:--entrypoint --envThis PR adds the missing option.