Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add logDone for TestBuildAddSingleFileToNonExistDir#8567

Merged
jessfraz merged 2 commits into
moby:masterfrom
LK4D4:add_log_done
Oct 17, 2014
Merged

Add logDone for TestBuildAddSingleFileToNonExistDir#8567
jessfraz merged 2 commits into
moby:masterfrom
LK4D4:add_log_done

Conversation

@LK4D4

@LK4D4 LK4D4 commented Oct 14, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@jessfraz

Copy link
Copy Markdown
Contributor

nice find!

@vieux

vieux commented Oct 14, 2014

Copy link
Copy Markdown
Contributor

LGTM

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix the test name to "TestBuildAddSingleFileToNonExistingDir" (the ing is missing) ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course :)

Signed-off-by: Alexandr Morozov <[email protected]>
@LK4D4

LK4D4 commented Oct 14, 2014

Copy link
Copy Markdown
Contributor Author

Added commit with names fix.

@tiborvass

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment
@jessfraz

Copy link
Copy Markdown
Contributor

LGTM

jessfraz pushed a commit that referenced this pull request Oct 17, 2014
Add logDone for TestBuildAddSingleFileToNonExistDir
@jessfraz jessfraz merged commit 5a20dc6 into moby:master Oct 17, 2014
@LK4D4 LK4D4 deleted the add_log_done branch October 17, 2014 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants