Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cleanup: integration-cli (get rid of errorOut)#8569

Merged
tiborvass merged 28 commits into
moby:masterfrom
jessfraz:Cleanup-errorOut-resp
Oct 17, 2014
Merged

Cleanup: integration-cli (get rid of errorOut)#8569
tiborvass merged 28 commits into
moby:masterfrom
jessfraz:Cleanup-errorOut-resp

Conversation

@jessfraz

@jessfraz jessfraz commented Oct 14, 2014

Copy link
Copy Markdown
Contributor

Nuke the errorOut function in integration-cli

@vieux

vieux commented Oct 14, 2014

Copy link
Copy Markdown
Contributor

:(

I hate errorOut

LGTM though

@jessfraz

jessfraz commented Oct 14, 2014

Copy link
Copy Markdown
Contributor Author

ya me too, especially the fmt.Sprintf in it but thats a whole other issue

@jessfraz

jessfraz commented Oct 14, 2014

Copy link
Copy Markdown
Contributor Author

well i could just get rid of it all together... and use t.Fatals... hmm yes I like this idea, I'm not going to close this, I'll just redo it

@jessfraz jessfraz force-pushed the Cleanup-errorOut-resp branch from b345366 to beb7771 Compare October 14, 2014 22:11
@jessfraz jessfraz changed the title Cleanup: test-integration-cli errorOut resp Cleanup: get rid of errorOut Oct 14, 2014
@jessfraz jessfraz changed the title Cleanup: get rid of errorOut Cleanup: integration-cli (get rid of errorOut) Oct 14, 2014
@tiborvass

tiborvass commented Oct 16, 2014

Copy link
Copy Markdown
Contributor

LGTM

@jessfraz

jessfraz commented Oct 16, 2014

Copy link
Copy Markdown
Contributor Author

I plan on squashing all these too it was for my sanity
On Oct 16, 2014 2:06 PM, "Tibor Vass" [email protected] wrote:

LGTM

—
Reply to this email directly or view it on GitHub
#8569 (comment).

@tiborvass

tiborvass commented Oct 16, 2014

Copy link
Copy Markdown
Contributor

Don't squash

@tiborvass

tiborvass commented Oct 16, 2014

Copy link
Copy Markdown
Contributor

I mean, idk, I personally prefer more commits, than one big commit.

@jessfraz

jessfraz commented Oct 16, 2014

Copy link
Copy Markdown
Contributor Author

Oh ok cool, I just didn't know, this is way more sane tho phew

On Thu, Oct 16, 2014 at 2:11 PM, Tibor Vass [email protected]
wrote:

I mean, idk, I personally prefer more commits, than one big commit.

—
Reply to this email directly or view it on GitHub
#8569 (comment).

jessfraz added 19 commits October 16, 2014 15:05
@jessfraz
Cleanup errorOut resp in commit test
3182ee5 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)

Cleanup errorOut resp in commit test

Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in port test
88d65cb 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in export test
b645df1 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in tag test
475235b 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in create test
6b858b5 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in nat test
1784284 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in kill test
0faf875 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in info test
b59d5a9 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in history test
f7b3a6b 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in links test
7d38ae7 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in diff test
ac62c54 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in docker_utils.go
73eadbc 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in search tests
ef787eb 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in ps tests
d33f2bd 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in inspect tests
ac24cab 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in rmi tests
0e3744e 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in save tests
0c87424 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in build tests
b1e3c9e 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in top tests
764030e 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in push tests
f013506 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in version tests
50c3e75 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp in images tests
dd248de 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp pull tests
eeb0097 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp exec tests
6f1c8ff 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp restart tests
9f52d8e 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp log tests
842d4b6 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut resp run tests
66ac742 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz
Cleanup errorOut remove errorOut functions
5af7fac 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: jfrazelle)
@jessfraz jessfraz force-pushed the Cleanup-errorOut-resp branch from beb7771 to 5af7fac Compare October 16, 2014 22:06
@jessfraz

jessfraz commented Oct 16, 2014

Copy link
Copy Markdown
Contributor Author

just rebased, ping @vieux

@LK4D4

LK4D4 commented Oct 16, 2014

Copy link
Copy Markdown
Contributor

So nice. LGTM

tiborvass added a commit that referenced this pull request Oct 17, 2014
@tiborvass
Merge pull request #8569 from jfrazelle/Cleanup-errorOut-resp
6ac9768 
Cleanup: integration-cli (get rid of errorOut)
@tiborvass tiborvass merged commit 6ac9768 into moby:master Oct 17, 2014
@jessfraz jessfraz deleted the Cleanup-errorOut-resp branch October 24, 2014 18:56
@fredlf fredlf mentioned this pull request Nov 5, 2014
Closed
@SvenDowideit SvenDowideit mentioned this pull request Nov 6, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jessfraz @vieux @tiborvass @LK4D4