Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Setting iptables=false should propagate to ip-masq=false#8612

Merged
crosbymichael merged 1 commit into
moby:masterfrom
jessfraz:8611-ip-masq-iptables
Oct 16, 2014
Merged

Setting iptables=false should propagate to ip-masq=false#8612
crosbymichael merged 1 commit into
moby:masterfrom
jessfraz:8611-ip-masq-iptables

Conversation

@jessfraz

Copy link
Copy Markdown
Contributor

Setting iptables=false should propagate to ip-masq=false

Closes #8611

Signed-off-by: Jessica Frazelle [email protected]

@tiborvass

Copy link
Copy Markdown
Contributor

@jfrazelle test please :P

@jessfraz

Copy link
Copy Markdown
Contributor Author

sure thing

@jessfraz

Copy link
Copy Markdown
Contributor Author

just might take a sec bc it requires writing stuff to start a daemon with options

@jessfraz jessfraz force-pushed the 8611-ip-masq-iptables branch from 8c64977 to 3893e22 Compare October 16, 2014 18:52
@jessfraz

Copy link
Copy Markdown
Contributor Author

updated with test

@LK4D4

LK4D4 commented Oct 16, 2014

Copy link
Copy Markdown
Contributor

LGTM

@tiborvass tiborvass added this to the 1.3.1 milestone Oct 16, 2014
@vbatts

vbatts commented Oct 16, 2014

Copy link
Copy Markdown
Contributor

LGTM

@crosbymichael

Copy link
Copy Markdown
Contributor

LGTM

crosbymichael added a commit that referenced this pull request Oct 16, 2014
Setting iptables=false should propagate to ip-masq=false
@crosbymichael crosbymichael merged commit d1aca04 into moby:master Oct 16, 2014
@jessfraz jessfraz deleted the 8611-ip-masq-iptables branch October 16, 2014 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--ip-masq flag default value breaks anyone who used to use --iptables

5 participants