Cleanup docs Dockerfile, so it matches best practices.#8717
Conversation
|
omg yes yours is way better I'm closing mine :) |
|
Build failure on drone, but that seems like a problem with the registry. |
|
LGTM 👍 |
|
ping @fredlf @jamtur01 @SvenDowideit @OSTezer for approval and/or discussion :) |
|
LGTM and thanks for doing it. |
|
LGTM |
There was a problem hiding this comment.
oh how i hate magic numbers :)
There was a problem hiding this comment.
actually, can you please update this to at least tell the reader what this hash is?
There was a problem hiding this comment.
That makes me think maybe we should write, or just mark up, a real-world Dockerfile with lots of comments. I know it helps me to be led through an actual example.
There was a problem hiding this comment.
@SvenDowideit, How about this just before the RUN and after the current comment:
# commit hash is the newest commit of SvenDowideit/mkdocs on
# docker-markdown-merge branch, it is used to break docker cache
# see: https://github.com/SvenDowideit/mkdocs/tree/docker-markdown-mergeThere was a problem hiding this comment.
Shouldn't it be, "commit hash of the newest commit from SvenDowideit/mkdocs..."?
|
@yosifkit thats enought for me - otherwise its a totally secret trip point - this way, it'll trip up everyone, but at least you can point to the docs. (ie, i don't catually think its a good idea to obfuscate, but it works). |
Docker-DCO-1.1-Signed-off-by: Joseph Ferguson <[email protected]> (github: yosifkit)
280445e to
9a03652
Compare
|
@SvenDowideit, updated with comment about commit id. |
|
LGTM, and many thanks :) |
|
@crosbymichael @tiborvass drone seems to have failed some tests - which should be unrelated to this PR - should I ignore drone and merge anyway? |
|
I would ignore bc the commit is signed off
|
Cleanup docs Dockerfile, so it matches best practices.
&&to beginning of lines to improve readabilityWORKDIRThanks to @tianon for the review so far 😄.
I made this and realized I had included the same changes as @jfrazelle in #8715, but I think this adds a few more tweaks to make it more readable.