builder: some small fixups + fix a bug where empty entrypoints would not override inheritance.#8744
Merged
Conversation
…not override inheritance. Docker-DCO-1.1-Signed-off-by: Erik Hollensbe <[email protected]> (github: erikh)
Contributor
|
LGTM |
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Oct 24, 2014
builder: some small fixups + fix a bug where empty entrypoints would not override inheritance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #8732. I also tacked on some spelling fixes and a formatting change to debug logging. There is a test as well.
The crux of the issue is multi-tiered:
[]evaluates to no content), the attributes and "original" line did not propagate to the evaluator.niland an empty array.entrypointevaluator, the switch statement would eagerly treat nil and empty arrays as equal regardless of how they were defined.