Thanks to visit codestin.com
Credit goes to github.com

Skip to content

builder: Restore /bin/sh handling in CMD when entrypoint is specified with JSON#8809

Merged
tiborvass merged 1 commit into
moby:masterfrom
erikh:builder_cmd_sh_fix
Oct 27, 2014
Merged

builder: Restore /bin/sh handling in CMD when entrypoint is specified with JSON#8809
tiborvass merged 1 commit into
moby:masterfrom
erikh:builder_cmd_sh_fix

Conversation

@erikh

@erikh erikh commented Oct 27, 2014

Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for -t

@tiborvass

Copy link
Copy Markdown
Contributor

For context: this PR is to restore pre-1.3 behavior of an unspecified corner case:
When ENTRYPOINT is specified with JSON, but CMD is not, the /bin/sh -c from CMD was not removed pre-1.3.

@tiborvass

Copy link
Copy Markdown
Contributor

LGTM

@tiborvass tiborvass added this to the 1.3.1 milestone Oct 27, 2014
@crosbymichael

Copy link
Copy Markdown
Contributor

needs rebase

… with JSON

Docker-DCO-1.1-Signed-off-by: Erik Hollensbe <[email protected]> (github: erikh)
@crosbymichael

Copy link
Copy Markdown
Contributor

LGTM

tiborvass added a commit that referenced this pull request Oct 27, 2014
builder: Restore /bin/sh handling in CMD when entrypoint is specified with JSON
@tiborvass tiborvass merged commit 55702ae into moby:master Oct 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants