Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix docker exec help messages.#8818

Merged
crosbymichael merged 1 commit into
moby:masterfrom
coolljt0725:fix_exec_help
Oct 31, 2014
Merged

Fix docker exec help messages.#8818
crosbymichael merged 1 commit into
moby:masterfrom
coolljt0725:fix_exec_help

Conversation

@coolljt0725

Copy link
Copy Markdown
Contributor

Signed-off-by: Lei Jitang [email protected]

The docker exec command help messages "Run a command in an existing container"
should be "Run a command in a running container".
"an existing container" would confuse the users since docker exec exactly run a command
in a running container.
docker-exec.1.md also description the docker exec command as
"Run a process in a running container."

@jessfraz

Copy link
Copy Markdown
Contributor

LGTM, the drone test fail is unrelated, docs team feel free to merge if you like it

@coolljt0725

Copy link
Copy Markdown
Contributor Author

@jfrazelle yes,I like it,feel free to merge it

@SvenDowideit

Copy link
Copy Markdown
Contributor

This needs the matching strings in cli.md and the man pages to be updated too. @coolljt0725 will you do it, or should I make a follow on PR?

@coolljt0725

Copy link
Copy Markdown
Contributor Author

@SvenDowideit Thanks,I'm doing it.The cli.md and docker/docker/flags.go will be updated too,am I miss any files?

@SvenDowideit

Copy link
Copy Markdown
Contributor

yup :) use grep to be sure, but there will be one in the docs/man dir.

@coolljt0725

Copy link
Copy Markdown
Contributor Author

@SvenDowideit The one in the docs/man is docker-exec.1.md and I don't think it need to be updated,docker-exec.1.md has described the docker exec command as
"Run a process in a running container."

@coolljt0725

Copy link
Copy Markdown
Contributor Author

update cli.md and docker/docker/flags.go

@SvenDowideit

Copy link
Copy Markdown
Contributor

@coolljt0725 I'm guessing you want to git push :)

@coolljt0725

Copy link
Copy Markdown
Contributor Author

@SvenDowideit update

@SvenDowideit

Copy link
Copy Markdown
Contributor

@coolljt0725 argh! something changed in master again, can you rebase please?

LGTM @fredlf @jamtur01

@coolljt0725

Copy link
Copy Markdown
Contributor Author

@SvenDowideit have rebased

@crosbymichael

Copy link
Copy Markdown
Contributor

LGTM

crosbymichael added a commit that referenced this pull request Oct 31, 2014
@crosbymichael crosbymichael merged commit 7cb1213 into moby:master Oct 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants