Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update host integration article#8822

Merged
fredlf merged 1 commit into
moby:masterfrom
wilsaj:patch-2
Oct 30, 2014
Merged

Update host integration article#8822
fredlf merged 1 commit into
moby:masterfrom
wilsaj:patch-2

Conversation

@wilsaj

@wilsaj wilsaj commented Oct 28, 2014

Copy link
Copy Markdown
Contributor

Update for changes in docker 1.2. Running the docker daemon with "-r=false" has been deprecated in favor of per-container restart policies.

@thaJeztah

Copy link
Copy Markdown
Member

(I'm on mobile, so unable to add inline comments)

Should the link to the previous version be a relative link? Ie drop the domain-name from the url? Just so that it is able to work on the staging/beta docs. Not sure, I'm not a maintainer

previous version

@wilsaj

wilsaj commented Oct 28, 2014

Copy link
Copy Markdown
Contributor Author

Good point. Updated the link.

@thaJeztah

Copy link
Copy Markdown
Member

Thanks!

@SvenDowideit

Copy link
Copy Markdown
Contributor

LGTM - @fredlf @jamtur01

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sentence is way too mega-long, it could probably be simplified by swapping things around :)

@wilsaj

wilsaj commented Oct 29, 2014

Copy link
Copy Markdown
Contributor Author

Ok, I've incorporated those suggestions and changed a few more things.

@SvenDowideit

Copy link
Copy Markdown
Contributor

@jamtur01 @fredlf

@wilsaj if you are able to squash your commits into one, that would be great - if not, I can make an update PR that does ti for you (as patch-1 often means you've used the github webui)

@wilsaj

wilsaj commented Oct 30, 2014

Copy link
Copy Markdown
Contributor Author

Yeah, no prob.

@wilsaj

wilsaj commented Oct 30, 2014

Copy link
Copy Markdown
Contributor Author

Squashed.

@wilsaj wilsaj force-pushed the patch-2 branch 2 times, most recently from 38e2b1d to 041576f Compare October 30, 2014 14:36

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comma after "i.e." please. I also think the sentence is flipped, and the clause "if restart policies don't suit your needs" should go at the beginning. Readers expect contextualizing info like this at the beginning.

@fredlf

fredlf commented Oct 30, 2014

Copy link
Copy Markdown
Contributor

LGTM once my copy edit nitpick is addressed. Will merge once that's fixed. Many thanks for the contribution.

@wilsaj wilsaj force-pushed the patch-2 branch 8 times, most recently from f3c5af1 to 9542ea7 Compare October 30, 2014 18:39
@wilsaj

wilsaj commented Oct 30, 2014

Copy link
Copy Markdown
Contributor Author

How's that?

Update for changes in docker 1.2. Running the docker daemon with "-r=false" has been deprecated in favor of per-container restart policies.

Signed-off-by: wilsaj <[email protected]>
@fredlf

fredlf commented Oct 30, 2014

Copy link
Copy Markdown
Contributor

Terrific! Thanks.

fredlf pushed a commit that referenced this pull request Oct 30, 2014
Update host integration article
@fredlf fredlf merged commit c3762c3 into moby:master Oct 30, 2014
SvenDowideit pushed a commit to SvenDowideit/docker that referenced this pull request Nov 6, 2014
Update host integration article
(cherry picked from commit c3762c3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants