Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ubuntulinux.md - old commands, typo, section movement#8837

Merged
SvenDowideit merged 1 commit into
moby:masterfrom
sawalls:patch-2
Oct 31, 2014
Merged

ubuntulinux.md - old commands, typo, section movement#8837
SvenDowideit merged 1 commit into
moby:masterfrom
sawalls:patch-2

Conversation

@sawalls

@sawalls sawalls commented Oct 29, 2014

Copy link
Copy Markdown
Contributor
  • Removed some commands related to autocomplete/symlinks that don't seem to be required anymore on Ubuntu 14.04
  • Fixed one minor typo ("see LINK for details," not "see LINK details")
  • Moved section "Giving non-root access" to top level, rather than being under Ubuntu 13 (the section isn't specific to Ubuntu 13, and even references Ubuntu 14).

Signed-off-by: Scott Walls [email protected]

@sawalls

sawalls commented Oct 29, 2014

Copy link
Copy Markdown
Contributor Author

I had trouble getting it to go to the other pull request, so this is a fixed version of: #8788

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm, do we really want to remove this softlink? some users find it useful to have docker in the path

or was the binary renamed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, the binary has been renamed. On my system, after a fresh install, 'which docker' gives '/usr/bin/docker', which seems to be a binary. (the legacy /usr/bin/docker.io is a symlink to docker now)

@SvenDowideit

Copy link
Copy Markdown
Contributor

LGTM - @fredlf @jamtur01

@jamtur01

Copy link
Copy Markdown
Contributor

LGTM

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize "Docker" please, unless it's in code. Here and below.

@fredlf

fredlf commented Oct 30, 2014

Copy link
Copy Markdown
Contributor

LGTM. Will merge as soon as my copy edit nitpick is addressed. Many thanks for the contribution.

- Removed some commands related to autocomplete/symlinks that don't seem to be required anymore on Ubuntu 14.04
- Fixed one minor typo ("see LINK _for_ details," not "see LINK details")
- Moved section "Giving non-root access" to top level, rather than being under Ubuntu 13 (the section isn't specific to Ubuntu 13, and even references Ubuntu 14).

Signed-off-by: Scott Walls <[email protected]>
@sawalls

sawalls commented Oct 31, 2014

Copy link
Copy Markdown
Contributor Author

Used git --amend to address capitalization.

If you'd rather have a separate commit with the corrections, I can split them up.

SvenDowideit added a commit that referenced this pull request Oct 31, 2014
ubuntulinux.md - old commands, typo, section movement
@SvenDowideit SvenDowideit merged commit 107898a into moby:master Oct 31, 2014
@SvenDowideit

Copy link
Copy Markdown
Contributor

LGTM :)

@sawalls sawalls deleted the patch-2 branch November 1, 2014 23:05
SvenDowideit added a commit to SvenDowideit/docker that referenced this pull request Nov 6, 2014
ubuntulinux.md - old commands, typo, section movement
(cherry picked from commit 107898a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants