Add docs for --dns-search=.#8839
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Use --dns-search=. if you don't wish to set the search domain.
Contributor
|
Thanks for this. Can you please update based on feedback. |
c890c2b to
4aacb25
Compare
Contributor
Author
|
@jamtur01 Thanks for your review. updated |
PR 6720 introduce that use `--dns-search=.` will not set `search` in `/etc/resolv.conf`. Signed-off-by: Huayi Zhang <[email protected]>
4aacb25 to
36ffbd7
Compare
Contributor
|
LGTM Ping @SvenDowideit @fredlf |
Contributor
|
LGTM and many thanks for the contribution. |
Contributor
There was a problem hiding this comment.
This needs a matching change in the code.
Signed-off-by: Huayi Zhang <[email protected]>
Contributor
|
Docs LGTM - @crosbymichael @vieux @tiborvass @jfrazelle |
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Oct 31, 2014
Add docs for --dns-search=.
SvenDowideit
pushed a commit
to SvenDowideit/docker
that referenced
this pull request
Nov 6, 2014
Add docs for --dns-search=. (cherry picked from commit 0f9f5f3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #6720 introduce that use
--dns-search=.will not setsearchin/etc/resolv.conf.