Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Skip V2 registry and immediately fallback to V1 when mirrors are provided#8901

Merged
crosbymichael merged 1 commit into
moby:masterfrom
dmcgowan:v2_registry_mirror_check
Nov 3, 2014
Merged

Skip V2 registry and immediately fallback to V1 when mirrors are provided#8901
crosbymichael merged 1 commit into
moby:masterfrom
dmcgowan:v2_registry_mirror_check

Conversation

@dmcgowan

@dmcgowan dmcgowan commented Nov 1, 2014

Copy link
Copy Markdown
Member

Since V2 registry does not yet implement mirrors, when mirrors are given automatically fallback to V1 without checking V2 first.

Closes #8688

…ided

Since V2 registry does not yet implement mirrors, when mirrors are given automatically fallback to V1 without checking V2 first.

Signed-off-by: Derek McGowan <[email protected]> (github: dmcgowan)
@dmcgowan

dmcgowan commented Nov 1, 2014

Copy link
Copy Markdown
Member Author

Relevant to #8688

@SvenDowideit

Copy link
Copy Markdown
Contributor

yes please :) can this be added to the 1.3.2 patch release milestone?

@shykes

shykes commented Nov 1, 2014

Copy link
Copy Markdown
Contributor

Yes.

@miminar

miminar commented Nov 3, 2014

Copy link
Copy Markdown
Contributor

--registry-mirror=<..> option works for me now. Thanks!

@dmp42

dmp42 commented Nov 3, 2014

Copy link
Copy Markdown
Contributor

LGTM

@tiborvass tiborvass added this to the 1.3.2 milestone Nov 3, 2014
@jessfraz

jessfraz commented Nov 3, 2014

Copy link
Copy Markdown
Contributor

LGTM

@crosbymichael

Copy link
Copy Markdown
Contributor

@timbot and @thockin

Can you please take a look and make sure this solves your issues?

@timbot

timbot commented Nov 3, 2014

Copy link
Copy Markdown
Contributor

@crosbymichael that works great for us. Thanks!

@crosbymichael

Copy link
Copy Markdown
Contributor

LGTM

crosbymichael added a commit that referenced this pull request Nov 3, 2014
Skip V2 registry and immediately fallback to V1 when mirrors are provided
@crosbymichael crosbymichael merged commit a7dea37 into moby:master Nov 3, 2014
@dmcgowan dmcgowan deleted the v2_registry_mirror_check branch June 15, 2016 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--registry-mirror is ignored in new V2 pull codepath

9 participants