Decode JSON to avoid ReadFile#8946
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
no need for &container, container is already a pointer.
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <[email protected]> (github: unclejack)
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <[email protected]> (github: unclejack)
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <[email protected]> (github: unclejack)
f5d3907 to
f665be5
Compare
Contributor
Author
|
@tiborvass Thanks! I've updated the code, PTAL. @cpuguy83 for changes to docker/volumes/ |
Contributor
|
LGTM Thanks @unclejack ! |
Member
|
LGTM |
2 similar comments
Contributor
|
LGTM |
Contributor
|
LGTM |
|
late to the party, but LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker ps -aanddocker imageswere allocating a lot of memory because ofioutil.ReadFile. Running those two commands 10000 times would cause the allocation of around 30-50 gigabytes because of ReadFile.This PR fixes some code paths for images, containers and volumes to use JSON decoding instead.