chore: Fix all broken test suites, improve CI workflow, remove Karma example #118
Conversation
|
Hmm, https://github.com/mark-wiemer/mocha-examples-2/actions/runs/14002878232/job/39212404440 is working on my fork, but only working for Node 20 in this repo. Looks like we have flaky download speeds. But Node 18 and Node 22 are failing for different reasons. Ref #119 for further research |
There was a problem hiding this comment.
🔥 This is great, thanks so much! I'd poked at this a couple of times last week but didn't make much progress. You got much much further than me. 😄
ACK that things aren't 100% stable right now, and that this is a big step in the right direction and a strong net positive. I think we can tackle the timeouts in a followup issue. There's got to be a way to download & install the necessary browsers ahead of time, cleanly.
Just a couple of quick nitpicks, feel free to just say "no I still like my way" and we can merge. 🚀
Co-authored-by: Josh Goldberg ✨ <[email protected]>
Co-authored-by: Josh Goldberg ✨ <[email protected]>
|
@JoshuaKGoldberg suggested changes have been made :) I don't have permission to merge. Please go ahead and merge if the changes look good :) |
package-lock.jsonfiles