Make sure interface types are initialized before inline mocking to avoid blocking code of static initializers. #2505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2505 +/- ##
=========================================
Coverage 86.53% 86.53%
Complexity 2779 2779
=========================================
Files 320 320
Lines 8341 8342 +1
Branches 1022 1022
=========================================
+ Hits 7218 7219 +1
Misses 851 851
Partials 272 272
Continue to review full report at Codecov.
|
TimvdLippe
requested changes
Dec 10, 2021
1c53db1 to
19dfa95
Compare
|
Good point, I stripped it to the minimum and merged it into a single test to avoid that the tests are run out of order. |
73c77c2 to
41557b8
Compare
41557b8 to
2b1e9a4
Compare
…oid blocking code of static initializers.
2b1e9a4 to
4635780
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2499
There was no explicit initialization of subinterfaces which can of course also declare initializers. Those were not executed at the right time and broke the mocking.